Luan Maik comments

Repositories
Issues
Comments

Results 6 comments of


                                            Luan Maik

Support for UTF-8 chars in subject

Why not merge?

Support for UTF-8 chars in subject

This is a relevant case to be observed https://github.com/vbuch/node-signpdf/issues/111

Support for UTF-8 chars in subject

What do you think to change this: ```js if(obj.valueTagClass === asn1.Type.UTF8) { obj.value = forge.util.decodeUtf8(obj.value); } ``` to this: ```js if(obj.valueTagClass === asn1.Type.UTF8) { try { obj.value = forge.util.decodeUtf8(obj.value); }...

Support for UTF-8 chars in subject

@Arturokin It's necessary to add test cases for this to determine if this is the correct fix.

Scheduled Jobs belongs to infrastructure?

Scheduled Jobs act like a client, equals webAPI project, so, I think it's Presentation layer

Application layer access to DbContext?

He is using INorthwindDbContext to access EF implementation, so it's correct, but I prefer to use the repository pattern.