RFM69 icon indicating copy to clipboard operation
RFM69 copied to clipboard

Fixed and improved SendACK. Keeps received info.

Open martiera opened this issue 11 years ago • 3 comments

Please review my improvements over sendACK.

martiera avatar Nov 14 '14 15:11 martiera

It's a good thing you added timeout while waiting for ack xmit but in my opinion you should resubmit the patch without the changes in whitespace.

kanflo avatar Nov 15 '14 12:11 kanflo

Yep, already doing :-)

M.

On 14:36, 15 Nov 2014, at 14:36, Johan Kanflo [email protected] wrote:

It's a good thing you added timeout while waiting for ack xmit but in my opinion you should resubmit the patch without the changes in whitespace.


Reply to this email directly or view it on GitHub: https://github.com/LowPowerLab/RFM69/pull/16#issuecomment-63170849

martiera avatar Nov 15 '14 13:11 martiera

//

Fixed patch. No whitespaces more.   Citējot Johan Kanflo [email protected] :

It's a good thing you added timeout while waiting for ack xmit but in my opinion you should resubmit the patch without the changes in whitespace.

Reply to this email directly or view it on GitHub.

 

martiera avatar Nov 15 '14 20:11 martiera