nodebb-plugin-s3-uploads icon indicating copy to clipboard operation
nodebb-plugin-s3-uploads copied to clipboard

Update aws sdk version and signature version

Open weatherstar opened this issue 8 years ago • 2 comments

weatherstar avatar Mar 30 '17 06:03 weatherstar

Can you give me a bit more info on your goal with this? is it just to update it or does this fix something?

On 30 March 2017 at 07:05, Weatherstar [email protected] wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/LouiseMcMahon/nodebb-plugin-s3-uploads/pull/23 Commit Summary

    1. update aws sdk

File Changes

Patch Links:

  • https://github.com/LouiseMcMahon/nodebb-plugin- s3-uploads/pull/23.patch
  • https://github.com/LouiseMcMahon/nodebb-plugin- s3-uploads/pull/23.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LouiseMcMahon/nodebb-plugin-s3-uploads/pull/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AULhNdvYej7Dy9zift2aIw0AKUyrNjqDks5rq0ZGgaJpZM4Mt5y2 .

LouiseMcMahon avatar Mar 30 '17 10:03 LouiseMcMahon

@LouiseMcMahon I'm sorry not to explain clearly. When using this plugin(with nodeBB 1.4.5), I get the following error:

AWS::S3::Errors::InvalidRequest The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256

I have checked some information said that I should use signature_version: 'v4' in aws-sdk like var s3 = new AWS.S3({ signatureVersion: 'v4' }); So I add it to the settings and then upgraded the version of aws-skd and it worked. That's the reason I created this pull request : )

weatherstar avatar Mar 31 '17 02:03 weatherstar