Update valgrind.rb

[lulyany]

Fix the problem on MacOS 11.6, using Homebrew. It often fails to git clone the repository from LouisBrunner/valgrind-macos.git. By changing "https" to "git", the problem can be fixed.

[github-actions[bot]]

Smart Diff (macos): Failure

Expected tolerance 'same' but got 'mixed-worse' instead

=================================================================== --- .github/macos-expected.txt +++ results-tests.txt @@ -15,8 +15,9 @@ memcheck/tests/client-msg (stderr) memcheck/tests/clientperm (stderr) memcheck/tests/cxx17_aligned_new (stderr) memcheck/tests/darwin/deep_badparam (stdout) +memcheck/tests/darwin/env (stderr) memcheck/tests/darwin/pth-supp (stderr) memcheck/tests/darwin/scalar (stderr) memcheck/tests/darwin/scalar_nocancel (stderr) memcheck/tests/deep-backtrace (stderr) @@ -33,24 +34,35 @@ memcheck/tests/leak-autofreepool-4 (stderr) memcheck/tests/leak-autofreepool-5 (stderr) memcheck/tests/leak-autofreepool-6 (stderr) memcheck/tests/leak-cases-full (stderr) +memcheck/tests/leak-cases-possible (stderr) memcheck/tests/leak-cases-summary (stderr) +memcheck/tests/leak-cycle (stderr) memcheck/tests/leak-delta (stderr) +memcheck/tests/leak-tree (stderr) memcheck/tests/leak_cpp_interior (stderr) memcheck/tests/lks (stderr) +memcheck/tests/long_namespace_xml (stderr) memcheck/tests/manuel1 (stderr) memcheck/tests/memalign_test (stderr) memcheck/tests/memcmptest (stderr) +memcheck/tests/mempool (stderr) +memcheck/tests/mempool2 (stderr) memcheck/tests/mismatches (stderr) +memcheck/tests/nanoleak2 (stderr) +memcheck/tests/nanoleak_dynsupp (stderr) +memcheck/tests/nanoleak_supp (stderr) memcheck/tests/origin1-yes (stderr) memcheck/tests/origin2-not-quite (stderr) memcheck/tests/origin3-no (stderr) memcheck/tests/origin4-many (stderr) memcheck/tests/origin5-bz2 (stderr) memcheck/tests/origin6-fp (stderr) memcheck/tests/overlap (stderr) +memcheck/tests/pointer-trace (stderr) memcheck/tests/post-syscall (stderr) +memcheck/tests/recursive-merge (stderr) memcheck/tests/sem (stderr) memcheck/tests/sized_delete (stderr) memcheck/tests/static_malloc (stderr) memcheck/tests/strchr (stderr) @@ -60,8 +72,11 @@ memcheck/tests/supponlyobj (stderr) memcheck/tests/suppvarinfo5 (stderr) memcheck/tests/test-plo-no (stderr) memcheck/tests/thread_alloca (stderr) +memcheck/tests/threadname_xml (stderr) +memcheck/tests/trivialleak (stderr) +memcheck/tests/undef_malloc_args (stderr) memcheck/tests/varinfo1 (stderr) memcheck/tests/varinfo2 (stderr) memcheck/tests/varinfo3 (stderr) memcheck/tests/varinfo4 (stderr) @@ -270,10 +285,8 @@ dhat/tests/copy (stderr) dhat/tests/empty (stderr) dhat/tests/sig (stderr) dhat/tests/single (stderr) -none/tests/allexec32 (stdout) -none/tests/allexec64 (stdout) none/tests/amd64/amd64locked (stdout) none/tests/amd64/sse4-64 (stdout) none/tests/async-sigs (stderr) none/tests/bug234814 (stdout) @@ -294,9 +307,8 @@ none/tests/ioctl_moans (stderr) none/tests/mmap_fcntl_bug (stderr) none/tests/nocwd (stdout) none/tests/nocwd (stderr) -none/tests/pth_2sig (stderr) none/tests/pth_cancel1 (stderr) none/tests/pth_cancel2 (stderr) none/tests/require-text-symbol-2 (stderr) none/tests/rlimit_nofile (stderr)

[github-actions[bot]]

Smart Diff (linux): Success

Check succeeded with tolerance 'same' (expected 'same' or better)

=================================================================== --- .github/linux-expected.txt +++ results-tests.txt

[LouisBrunner]

The canonical way to install this is through https://github.com/LouisBrunner/homebrew-valgrind (if I remember right, it's been setup for a while) so that might be a better place to patch it? What kind of issues are you seeing on 11.6? (which isn't supported so I guess it just fails afterwards?) Also are there any recommendation from brew about using https vs git protocol for repositories?

[lulyany]

The error I met is typical: https fatal: HTTP request failed

One possible reason is that git or curl is outdated. Git use curl to transfer.

But we can view this from another perspective. Git protocol and SSH protocol are four layer transport protocols, while HTTP is a seven layer transport protocol. Limited by the characteristics of HTTP protocol, HTTP has transmission restrictions, timeout and other problems in Git related operations. This problem is particularly obvious in the transmission of large warehouses. Compared with HTTP, GIT and SSH protocols are simpler and more stable in transmission. refer to this for details of git

[Zialus]

Should this file be removed from this repo to avoid confusion?

[LouisBrunner]

valgrind.rb has now been deleted in favor of LouisBrunner/homebrew-valgrind