dnd-multi-backend icon indicating copy to clipboard operation
dnd-multi-backend copied to clipboard

Removed type module

Open maiconcarraro opened this issue 3 years ago • 3 comments

React working: image

Let me know if that's the only thing that was missing, or which commands to reproduce your error.

maiconcarraro avatar Sep 15 '22 05:09 maiconcarraro

Coverage Status

Coverage remained the same at 100.0% when pulling 3c7208ef3064e75bf9fe8dcf6e63c72063bc4306 on maiconcarraro:main into 7895d53d32bdf6a216d3ac102ef7b39f58c96363 on LouisBrunner:main.

coveralls avatar Sep 16 '22 17:09 coveralls

Hi @maiconcarraro,

Thanks a lot for your contribution! 😄

I don't mind removing it if that's the way forward, but why does it work for other libraries like react-dnd (see here)?

LouisBrunner avatar Sep 16 '22 17:09 LouisBrunner

Hi @maiconcarraro,

Thanks a lot for your contribution! 😄

I don't mind removing it if that's the way forward, but why does it work for other libraries like react-dnd (see here)?

Not sure about this npm-explorer link, but if you check their offical github repo I dont see the mention to it: https://github.com/react-dnd/react-dnd/blob/v16.0.0/package.json

maiconcarraro avatar Sep 16 '22 17:09 maiconcarraro

@maiconcarraro You are looking at the wrong package.json: https://github.com/react-dnd/react-dnd/blob/main/packages/react-dnd/package.json 😉

LouisBrunner avatar Sep 21 '22 16:09 LouisBrunner

@maiconcarraro You are looking at the wrong package.json: https://github.com/react-dnd/react-dnd/blob/main/packages/react-dnd/package.json 😉

My bad =/ not sure how to help right now, I can take a look later, was using dnd-kit for now since it was an urgent delivery

maiconcarraro avatar Sep 22 '22 20:09 maiconcarraro

Hi @maiconcarraro,

Thanks again for this PR!

I found an alternative way to fix this issue (moving to esbuild to avoid babel/webpack wackyness) so I'll be closing this PR.

LouisBrunner avatar Dec 10 '22 17:12 LouisBrunner