lottie-js icon indicating copy to clipboard operation
lottie-js copied to clipboard

Fix: Optional text fill color

Open beve opened this issue 2 years ago • 2 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [x] Build (yarn build) was run locally and any changes were pushed
  • [x] Lint (yarn lint) has passed locally and any fixes were made for failures

Please check the type of change your PR introduces:

  • [x] Bugfix

What is the current behavior?

A default black color is always applied to the text. It is therefore impossible to display a text with a stroke and a transparent background.

image

What is the new behavior?

Text color is now optional.

Result:

image

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Here the link of a generated json using the patched lottie-js version.

beve avatar Apr 29 '22 14:04 beve

⚠️ No Changeset found

Latest commit: 4301426d74bed03891760b15be09f46fa8fe5e75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 29 '22 14:04 changeset-bot[bot]

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jun 29 '22 02:06 github-actions[bot]