obsidian-folder-notes icon indicating copy to clipboard operation
obsidian-folder-notes copied to clipboard

'Only open folder notes through the name' Setting Causes Inconsistent Styling

Open mackereldev opened this issue 1 year ago • 1 comments

I've noticed that when the setting 'Only open folder notes through the name' is disabled, it causes the folder collapse icon to shift ~~and overflow ellipses on file explorer items to no longer appear~~. This is inconsistent with when the option is enabled, and with vanilla Obsidian. I think it's caused by flex elements not supporting ellipsis overflow on their text component, but I'm not certain.

I've created a proposed fix here by I don't fully understand the implications of changing these styling rules. Have I overlooked something or am I clear to make a PR?

Edit: reverted changes made to the folder collapse icon because that issue was caused by a conflict with Relay.

mackereldev avatar Nov 20 '24 05:11 mackereldev

Yeah I've also noticed this recently. Should this add-on be touching the styling of those elements?

The only functions I see that would get involved is the "hide collapse icon" option and the folder note overview

Jon-dog avatar Dec 22 '24 14:12 Jon-dog

Can you try out the latest beta to see if it is fixed there?

LostPaul avatar Jun 16 '25 13:06 LostPaul

Looks to be gone now, which is good. A minor issue from the style updates is that if I open a folder with only a folder note, a single pixel of the outline column shows. This seems to happen whether I have Hide folder note enabled or not.

Tried disabling every style add-on I had + going back to the default theme and it was still there.

Image

Jon-dog avatar Jun 16 '25 15:06 Jon-dog

Looks to be gone now, which is good. A minor issue from the style updates is that if I open a folder with only a folder note, a single pixel of the outline column shows. This seems to happen whether I have Hide folder note enabled or not.

Tried disabling every style add-on I had + going back to the default theme and it was still there.

Image

Can you reproduce it in a sandbox vault?

LostPaul avatar Jun 16 '25 18:06 LostPaul

Created one from scratch and only installed Brat + Folder Note, and it still appears

I know it's really tiny, but in coloured dark themes, a bright pixel sticks out Image

If you highlight the note folder, you can see that the folder below also moves a pixel down Video

Jon-dog avatar Jun 17 '25 02:06 Jon-dog

Should be fixed now, was a bit more complicated than I thought.

LostPaul avatar Jun 17 '25 10:06 LostPaul

Looks good to me now, I can't see any stray pixels

Jon-dog avatar Jun 18 '25 00:06 Jon-dog