TR1X icon indicating copy to clipboard operation
TR1X copied to clipboard

Published 20 hours ago • verified publisher icon LostArtefacts

Screenshot bugs during FMVs

Open Richard-L opened this issue 3 years ago • 8 comments

It looks like you can crash the game if you hit the PRINT key for a screenshot during the FMVs before the title screen. Tried both .RPL and .FMV:

image

Curiously during a later FMV (I tried "LIFT"), the PRINT screen will fail first but the game stays alive, and consequent PRINT hits will take screenshots as expected. 20220219_141339_Cut_Scene_1

Richard-L avatar Feb 19 '22 13:02 Richard-L

Works for me

20220219_213339_Level_-1 20220219_213339_Level_-1_2 20220219_213340_Level_-1 20220219_213340_Level_-1_2 20220219_213341_Level_-1 20220219_213341_Level_-1_2 20220219_213341_Level_-1_3 20220219_213341_Level_-1_4 20220219_213341_Level_-1_5 20220219_213342_Level_-1 20220219_213342_Level_-1_2 20220219_213343_Level_-1 20220219_213343_Level_-1_2 20220219_213343_Level_-1_3 20220219_213343_Level_-1_4 20220219_213351_Title 20220219_213351_Title_2 20220219_213351_Title_3 20220219_213352_Title 20220219_213404_Title 20220219_213404_Title_2 20220219_213404_Title_3 20220219_213405_Title 20220219_213418_Cut_Scene_1 20220219_213418_Cut_Scene_1_2 20220219_213418_Cut_Scene_1_3 20220219_213419_Cut_Scene_1

rr- avatar Feb 19 '22 21:02 rr-

Huh, strange. Can anyone else reproduce this?

Richard-L avatar Feb 19 '22 23:02 Richard-L

Huh, strange. Can anyone else reproduce this?

I tested core, cafe and snow (both avi and rpl), and screenshotting with windows key + prt sc (laptop) works just fine.

(Slightly offtopic: screenshotting during pictures (eidos, credits) results in a black screenshot. Should this be an issue or not?)

Rapora9 avatar Feb 20 '22 11:02 Rapora9

@Rapora9 Isn't that Window's native command for screenshot taking? I meant TR1M's own function where it saves to png or jpg in the base folder.

Richard-L avatar Feb 20 '22 14:02 Richard-L

Hmm, I see. With that command I get a screenshot to both in the game's own folder and Window's folder too. If I only press prt sc during Eidos, core or cafe, then there is a chance of the game crashing without an error message.

Btw, I'm saving as .PNG. Saving as .JPG crashes too sometimes, but maybe not as frequently?

Rapora9 avatar Feb 20 '22 15:02 Rapora9

Okay yeah that's the same behaviour then. PNG here too. Would be surprised if it made a difference.

Richard-L avatar Feb 20 '22 19:02 Richard-L

T1M also crashes for me when taking .PNG format screenshots of the edios screen and all startup FMVs. It doesn't crash when I take screenshots in .JPG format instead.

aredfan avatar Feb 21 '22 07:02 aredfan

Okay so perhaps it is related to the format after all

Richard-L avatar Feb 21 '22 07:02 Richard-L

The engine crashes because here:

https://github.com/rr-/Tomb1Main/blob/9f0675f53ae20fc73a1522308ff6d4f10177ac20/src/game/shell.c#L46

g_CurrentLevel is -1 and snprintf() crashes in a point where it evaluates the length of that parameter.

carlo-bramini avatar Jan 06 '23 12:01 carlo-bramini