spyglass
spyglass copied to clipboard
Don't insert lab member when creating lab team
Description
related to #979
This is the logic of creating lab member and lab team upon NWB ingestion:
- Read
experimenter
field from the nwb file, which contains names inlast, first
format (can be a list of multiple experimenters) - For each experimenter, insert a row in
LabMember
by converting thelast, first
format tofirst last
format (line 62 ofcommon_lab.py
) - In addition, for each experimenter, insert a row in
LabTeam
, again withfirst last
as theteam_name
(line 68 ofcommon_lab.py
) - During this, insert the lab member with
first last
intoLabMember
again (line 195 ofcommon_lab.py
)
Step 4 throws an error for me because the name Lee, Kyu Hyun
has been converted to Kyu Hyun Lee
and then passed to decompose_name
, which throws an error. So this change comments out that step.
I have verified that this removes the problem from #979 but not sure if the line is important for something else. Does anyone know?
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Please list issues fixed or closed by This PR.
- Fixes #000: How this PR fixes the issue
-
path/file.py
: Description of the change -
path/file.py
: Description of the change
-
- Fixes #000: How this PR fixes the issue
-
path/file.py
: Description of the change -
path/file.py
: Description of the change
-
Checklist:
- [ ] This PR should be accompanied by a release: (yes/no/unsure)
- [ ] If release, I have updated the
CITATION.cff
- [ ] This PR makes edits to table definitions: (yes/no)
- [ ] If table edits, I have included an
alter
snippet for release notes. - [ ] I have updated the
CHANGELOG.md
with PR number and description. - [ ] I have added/edited docs/notebooks to reflect the changes