spyglass icon indicating copy to clipboard operation
spyglass copied to clipboard

Allow recompute via `_make_file` func

Open CBroz1 opened this issue 5 months ago • 1 comments

Description

This PR adds the ability to recompute when fetching a non-existent file from v1.SpikeSortingRecording, adding some infrastructure to support expanding this tool in the future. To facilitate this, I add ...

  • A standard of a _make_file func that other tables can implement in the future.

  • An imperfect NWB hashing tool

    • Chunking the byte stream doesn't work because replacing values impacts checksums (thanks Ryan!)
    • Currently, I look at the first 4k rows of a dataset
    • Problematic fields for us include values below this threshold, but we would need to change for other tables
      • general/experimenter
      • general/extracellular_ephys/electrodes/filtering
      • general/extracellular_ephys/electrodes/group
      • general/extracellular_ephys/electrodes/location
      • intervals/epochs/tags
  • Tests for round-trip file deletion, then calling fetch_nwb

Checklist:

  • [X] No. This PR should be accompanied by a release: (yes/no/unsure)
  • [X] N/a. If release, I have updated the CITATION.cff
  • [X] Yes. This PR makes edits to table definitions: (yes/no)
  • [X] Yes. If table edits, I have included an alter snippet for release notes.
  • [X] N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • [X] Yes. I have updated the CHANGELOG.md with PR number and description.
  • [ ] I have added/edited docs/notebooks to reflect the changes

CBroz1 avatar Sep 06 '24 20:09 CBroz1