spyglass icon indicating copy to clipboard operation
spyglass copied to clipboard

Periph table fallback on TableChain for experimenter summary

Open CBroz1 opened this issue 7 months ago • 4 comments

Description

Thanks, @MichaelCoulter for submitting #1031

Previously, the SpyglassMixin delete process inherited banning of peripheral tables behavior, which is useful in the case of long-distance restrictions, and failed to fully inherit ignoring of non-spyglass tables. This cropped up for both (a) delete permission via the session table, and (b) downstream descendants for deleting part-masters.

I address this by giving TableChain a new fallback for the path between two nodes that includes peripheral tables, if no connection was previously found. This allows tables like IntervalLinearizedPosition to find a session connection, and ignores custom tables when checking downstream for part-master deletes.

Checklist:

  • [x] No. This PR should be accompanied by a release: (yes/no/unsure)
  • [x] N/a. If release, I have updated the CITATION.cff
  • [x] No. This PR makes edits to table definitions: (yes/no)
  • [x] N/a. If table edits, I have included an alter snippet for release notes.
  • [x] No. If this PR makes changes to position, I ran the relevant tests locally.
  • [x] I have updated the CHANGELOG.md with PR number and description.
  • [x] N/a. I have added/edited docs/notebooks to reflect the changes

CBroz1 avatar Jul 15 '24 21:07 CBroz1