MBW.BlueRiiot2MQTT icon indicating copy to clipboard operation
MBW.BlueRiiot2MQTT copied to clipboard

ReportUnchangedValues: Only report values that "could've" been updated

Open LordMike opened this issue 3 years ago • 0 comments

Ah, I see. Nice to know also, that their serverside thingy is likely javascript :P

When that exception occurs, the entire update loop will be disrupted (and run again later). You should see values like last_bad on the operational sensor in HASS. See https://github.com/LordMike/MBW.BlueRiiot2MQTT/blob/b6a71ba204141cd6fb1e520b04576ac0222b2c3f/MBW.BlueRiiot2MQTT/Service/PoolUpdater/SingleBlueRiiotPoolUpdater.cs#L92-L97 for details.

It will affect the unchanged logic, as after the exception occurs, the call to MarkAllValuesDirty won't happen.

But then again, once the error subsides, all values should again be pushed.

Actually, I now see another issue: When a pool (any pool if you have several) is updated, then all values are pushed again, even the ones that weren't updated... Like another pools values, or the other sensors BR2MQTT provides... Should probably change that to just the sensors that could've been updated.

Originally posted by @LordMike in https://github.com/LordMike/MBW.BlueRiiot2MQTT/issues/48#issuecomment-850809480

LordMike avatar May 29 '21 10:05 LordMike