Brightness icon indicating copy to clipboard operation
Brightness copied to clipboard

Discussion: Mockup for V3

Open LordAmit opened this issue 6 years ago • 8 comments

@jahan-addison @apandada1 @sazid https://github.com/LordAmit/Brightness/blob/mockups/Brightness_controller_v3.jpeg?raw=true

Check this out and let me know your thoughts. 💃

LordAmit avatar Jun 28 '19 18:06 LordAmit

Looks great 🎉! Were you thinking of updating the stack any? Such as PyQt5/python 3.6+ :)

A new homepage could be nice too! We could go something simple like wp and just keep it up to date.

jahan-addison avatar Jun 29 '19 00:06 jahan-addison

Also, check this out! https://github.com/gmarull/qtmodern

jahan-addison avatar Jun 29 '19 01:06 jahan-addison

Also, we need to implement setup.py for Debian packaging.

archisman-panigrahi avatar Jun 29 '19 10:06 archisman-panigrahi

@jahan-addison planning to go for PySide2. QtModern looks nice and all - but I am looking for something which will probably be maintained and supported for a long time.

@apandada1 - elaboration please :) Are we talking about continuous building?

LordAmit avatar Jun 29 '19 19:06 LordAmit

I am not sure what you meant by continuous building. The setup.py file is used to generate the /usr/bin/brightness-controller file, which will call the other python files.

Previously we called init.py inside /usr/bin/brightness-controller to run the program. While it works, it is discouraged (by Debian maintainers) to run the program like this.

archisman-panigrahi avatar Jun 30 '19 15:06 archisman-panigrahi

@LordAmit If you use something only once, does it matter the support? Once your mockup is implemented I dont see how a qt library's support changes anything.

jahan-addison avatar Jun 30 '19 17:06 jahan-addison

It goes both ways, to be honest. Wrappers assume that libraries do not change, libraries assume that GUI APIs do not change.

All of these change at one time or another, inevitably breaking things. Choosing stable options help increase maintainability by breaking less frequently. :grin:

@apandada1 - probably you are talking about this then?

https://packaging.python.org/tutorials/packaging-projects/

Gotcha :dancer:

LordAmit avatar Jun 30 '19 22:06 LordAmit

@LordAmit Stable != Support, but either way makes sense. I saw you already started a kanban board. When you fully flesh out expected MVP features, I'd love to grab a couple issues and get started 👍

jahan-addison avatar Jun 30 '19 22:06 jahan-addison