Gregorio Litenstein
Gregorio Litenstein
> Here is the top of the backtrace > > ``` > Thread 5 Crashed:: com.apple.audio.IOThread.client > 0 performous 0x0000000104161fef Music::prepare() + 511 (audio.cc:209) > 1 performous 0x000000010416da29 Output::callbackUpdate() +...
Nope, it's the same. *shrugs* EDIT: I'm an idiot, ignore me. I merged master already there. Before your fixes, line 209 was line 208 in master: `double pstart = sSongs->getSongs().currentPtr()->preview_start;`...
> @Lord-Kamina Is this still a thing or has this been fixed in #545 ? #545 should fix it.
https://github.com/performous/performous/pull/545/commits/d225eaca1c8d2b26a5f896bf09c1ec0abaa8145c This is the fix I had implemented in #545 btw. Should probably be cherry-pickable.
> I don't see why all of these is required: > > - Json should be a header only library, why do we need to add the include of the...
I removed the change to `reload_internal` entirely. I still left three commits, with the removal of the `#IFDEF WEBSERVER` bit on its own commit.
The build failure on Mac is probably cause you forgot to `#include `
> Gents, this is still draft, I'm trying to address #671, and #417 and maybe #160 at some point... review those at your own risks, I may completely rewrite any...
Hey, just necroing to say I'd really like to see this merged. I can help resolving conflicts and such, but I don't know what outstanding issues there may be with...
As I said on Discord,I think it's in our best interest to have a custom NSIS installer anyway. There is one already (inline) on the mxe build scripts, although it...