Gleb Kashkin

Results 23 comments of Gleb Kashkin

> Gleb, thanks for the changes. > > Patch implements breaking change - it changes a way how we print a string with newlines inside. According to discussion in [SO](https://stackoverflow.com/questions/3790454/how-do-i-break-a-string-in-yaml-over-multiple-lines#21699210)...

Set as unready for merge, until we decide if the change should be integrated into tarantool.compat.

Don't merge until new reviews!

A problem with the patch was detected. It breaks console connection via socket when eos is changed, because `\set output lua,eos=` was set up to change only one remote instance,...

CI will fail, until we merge tarantool/msgpuck#21.

1. Wiki page is a work in progress. 2. Will fix soon. 3. 1. FIXME mark questions that are open, and reviewer input is required. 2. Maybe 'do not touch'...

9. I've rechecked Lua style guides, there is now no mentioning of line length, last time I checked there was 120 chars for Lua. There is no mentioning of ban...

> checkpatch failed: https://github.com/tarantool/tarantool/actions/runs/3054424665/jobs/4926326306 It's a false positive, I filed an [issue](https://github.com/tarantool/checkpatch/issues/24).

Created alternative version, that doesn't trigger checkpatch false positive.