SWL2001 icon indicating copy to clipboard operation
SWL2001 copied to clipboard

aes_encrypt duplicate definition linking error + ideas for fix

Open cmorganBE opened this issue 1 year ago • 1 comments

aes_encrypt() symbol is a common one, wolfssl and/or some other ssl modules appear to define the same symbol.

Would it be acceptable to rename the public functions in aes.h to add a 'lora_' prefix? like lora_aes_encrypt()?

If so I can open a PR with said change.

I'm guessing there may be ways to fix this with various build options but that seemed like a significant amount of additional effort, although fewer changes to the stack here.

Thoughts? We'd like to not carry any local changes around (and today we've renamed aes_encrypt() to lora_aes_encrypt() to resolve this issue).

cmorganBE avatar Jun 24 '24 14:06 cmorganBE

Hi, We will evaluate feasibility for the next release. Many thanks,

opeyrard avatar Jun 25 '24 08:06 opeyrard