LoRaMac-node icon indicating copy to clipboard operation
LoRaMac-node copied to clipboard

Secure-Element Preprocessor definition ifndef wrapping

Open bdesterBE opened this issue 1 year ago • 1 comments

Hello,

I would like to open a pull request to simply wrap each define in src/peripherals/soft-se/se-identity.h with #ifndef tags. For example:

/*!
 * App/Join server IEEE EUI (big endian)
 */
#ifndef LORAWAN_JOIN_EUI
#define LORAWAN_JOIN_EUI
#endif

This would allow users to overwrite these values from application level CMakeLists.txt files without a warning being produced, and removes the need to modify LoRaMac-node directly with hard-coded values when it is being used as a submodule.

Thanks, Brandon

bdesterBE avatar Jan 04 '24 20:01 bdesterBE

Bedankt voor uw email.

Ik ben afwezig tot maandag 15 januari. E-mail gericht aan dit e-mailadres zal niet tussentijds worden gelezen of worden doorgestuurd. Voor dringende vragen verzoek ik u contact op te nemen met P. de Smit via @.*** Bedankt voor uw begrip.

Fijne kerstdagen en een gelukkig Nieuwjaar gewenst!

Met vriendelijke groet, ing. Peter Boudewijns CLICKEY solutions @.***

CLICKEY solutions: +31-162-511517 Lissenveld 47c, 4941 VL Raamsdonksveer, The Netherlands http://www.clickey.eu


Thank you for your e-mail.

I am out of office until Monday January 15th. Your e-mail will not be read or forwarded until then. For urgent matters please contact P. de Smit at @.*** Thank you for your understanding.

Wishing you a Merry Christmas and a happy new year!

Kind regards, ing. Peter Boudewijns CLICKEY solutions @.***

CLICKEY solutions: +31-162-511517 Lissenveld 47c, 4941 VL Raamsdonksveer, The Netherlands http://www.clickey.eu

pjb-loxius avatar Jan 04 '24 20:01 pjb-loxius