LoRaMac-node icon indicating copy to clipboard operation
LoRaMac-node copied to clipboard

Wrong comment in ProcessRadioRxDone() ?

Open sborshch opened this issue 4 years ago • 1 comments

In LoRaMac.c function ProcessRadioRxDone() comment says "Abort in case if the device isn't joined yet" but code actually aborts if device IS joined:

            if( ( Nvm.MacGroup2.NetworkActivation != ACTIVATION_TYPE_NONE ) && ( Nvm.MacGroup2.IsRejoinRequestPending == false ) )
            {
                MacCtx.McpsIndication.Status = LORAMAC_EVENT_INFO_STATUS_ERROR;
                PrepareRxDoneAbort( );
                return;
            }

sborshch avatar Dec 21 '21 08:12 sborshch

Hi @sborshch ,

thanks for the report. Yes thats true. We will fix that.

djaeckle avatar May 11 '22 14:05 djaeckle