Loop icon indicating copy to clipboard operation
Loop copied to clipboard
verified publisher icon LoopKit

Loop crashes if an override is dragged to bottom of screen while reordering

Open bedtime4bonzos opened this issue 1 year ago • 4 comments

Describe the bug Loop crashes if an override is dragged to bottom of screen while reordering

Attach an Issue Report

  • n/a

To Reproduce Steps to reproduce the behavior:

  1. Open the Overrides screen
  2. Create 2 or more overrides
  3. Tap "Edit"
  4. Drag any override to the very bottom of the screen
  5. Loop crashes

Expected behavior Loop shouldn't crash

Screenshots

  • n/a

Phone

  • iPhone 6S
  • iOS 15.8.3

Loop Version

  • 3.4.1

CGM

  • n/a

Pump

  • n/a

Additional context

  • n/a

bedtime4bonzos avatar Aug 16 '24 19:08 bedtime4bonzos

Hi @bedtime4bonzos, Could you provide a screen recording? This makes the crash reproducable

bastiaanv avatar Aug 16 '24 20:08 bastiaanv

If you have any trouble reproducing the issue with the steps above, let me know and I'll do that. Thanks for looking into it.

bedtime4bonzos avatar Aug 16 '24 20:08 bedtime4bonzos

@bedtime4bonzos See: https://github.com/LoopKit/LoopKit/pull/540

bastiaanv avatar Aug 18 '24 18:08 bastiaanv

@bastiaanv Fast work, thanks!

bedtime4bonzos avatar Aug 19 '24 14:08 bedtime4bonzos