swords-and-ravens icon indicating copy to clipboard operation
swords-and-ravens copied to clipboard

Add check to swap to later house cards only for non vassals

Open gereon77 opened this issue 2 years ago • 1 comments

https://github.com/Longwelwind/swords-and-ravens/blob/79bcf713d1421e7131b3f27b23fe334ba15408ba/agot-bg-game-server/src/common/ingame-game-state/action-game-state/resolve-march-order-game-state/combat-game-state/post-combat-game-state/PostCombatGameState.ts#L458

gereon77 avatar Aug 27 '22 07:08 gereon77

In case a house was replaced by a player the later house cards check not null might not be enough

gereon77 avatar Aug 27 '22 07:08 gereon77

No real issue at all. markHouseAsUsed() is only called for none vassals. The check is done before.

gereon77 avatar Sep 09 '22 17:09 gereon77