Aleksandr Logunov
Aleksandr Logunov
We also need someone from nearcore-codeowners to get an approval for merge.
Can we use `RawTrieNodeWithSize` structure to avoid code duplication? It feels it satisfies the same needs as `TrieProofLeaf/Extension/Branch`. If we modify trie impl at some point, it will be enough...
> There’s one difference which I don’t know if I understand fully. The Branch variant has child index in the proof. This means that the proof can be verified without...
We decided to merge it with https://github.com/near/nearcore/pull/7429, after finishing it we just close this one
(deleted)
What if rocksdb issues list is helpful here? This one is quite curious: https://github.com/facebook/rocksdb/issues/3961 I use command `cargo test --release --package runtime-tester --lib --features nearcore/no_cache -- perf_cliff --exact --nocapture`. When...
I'll leave a review on Monday/Tuesday UPD: let it be Wednesday because today I took another deep look on https://github.com/near/nearcore/pull/7445, and there is no rush
Not implemented error was related to https://github.com/near/nearcore/issues/6726 and most likely says that either db is corrupted or nearcore wasn't upgraded to 1.26. But downloading backup should resolve the first issue....
@robin-near could you review?
@robin-near ping :)