Feature request: Pre run and post run scripts

[gcarreno]

Hey Don(@LongDirtyAnimAlf),

While answering to #372 and I almost put something there by mistake. I think I was thinking of Lazarus Run Options.

My idea is to have 2 TEdits on the Setup+ button, one with a script that runs before you start the whole process and the other runs when the whole process ends. And maybe a TCheckBox on the post, to tell you if you run it only upon success?

Edit: Maybe the checkbox is not needed if a boolean is passed to the post script indicating success.

I would have a use for that to do what I explained in #372. This would do the 3 copy instructions without me doing them every time and forgetting them sometimes.

Hope my idea is clearly explained. If not, please shoot some questions my way.

Many thanks in advance!!

Cheers, Gus

[michael-ring]

Could be a valid solution for #372, I could do a rsync of relevant files to a safe location after a successful build. Is there a need to make this configurable with the checkbox or isn't it good enough when the script only runs on success? Is there actually a need for a prerun script?

[gcarreno]

Hey Michael(@michael-ring),

Pre and Post is for completeness. If Don implements only one, there's gonna be someone nagging for the other.

In terms of the Checkbox I need to propose that it should not exist and should be passed as a param to the post script. That way you can chose to do different things depending on success.

Cheers, Gus

[LongDirtyAnimAlf]

This feature request has been implemented in a different manner. https://github.com/LongDirtyAnimAlf/fpcupdeluxe/releases/tag/1.8.2s A history tabsheet has been added. Previous revisions can be selected. Please test. Thanks.

[gcarreno]

Hey Don(@LongDirtyAnimAlf)

I'm really glad you were able to give a solution to @michael-ring issue #372.

But I have to disagree that this implements the pre and post-run scripts feature request I have detailed here and also explained further on the forum.

I'm really sorry to ask, but have you confused the issues?

I sincerely hope so, because I would love that you would think about the scripts and not the latest successful build to date.

As usual, many thanks for the time you spend reading and considering these proposals. I really appreciate it and I don't want to make you feel antagonised.

Cheers, Gus

[LongDirtyAnimAlf]

Hello Gus,

I do understand your request. And also your desire, as this seems easy to implement. However, its not that easy. The source base is very old. And fpcupdeluxe is nothing more than a (intelligent) GUI around commandline fpcup. This makes this feature hard to implement. First, I need to implement this on a command line level, before translating into the GUI.

The addition of the history feature is (at the moment) more suitable for fpcup(deluxe).

I will leave this issue open, and mark it as a feature request not to be forgotten !

[gcarreno]

Hey Don(@LongDirtyAnimAlf),

I've had a quick glance at the changes you did on commit 1337451 and it kinda looks like you're preparing for a better implementation than what I was thinking of.

Am I correct in thinking that you're gonna allow batch/shell and Object Pascal scripts? Not quite sure about the last one, but at least from the file dialog filters, I'm betting on the first 2, right?

Cheers, Gus