LonelyCat124

Results 139 comments of LonelyCat124

I think I wasn't sure on this/couldn't find a good use-case for symbol tables being equal, as I thought they were only at the routine level (and it didn't make...

My vague feeling on this is that the addition statements should be False, but I could be persuaded either way. I think if the addition statements and symbol tables are...

We're still pretty on topic I think, statement equality entirely depends on symbol equality at this point (it essentially recurses down to the point where it compares symbols assuming everything...

The loc which is causing the issue seems to be here: ``` ref.replace_with(node.children[dummy_args.index(ref.symbol)].copy()) ``` The example I'm looking at (which is essentially the same as Sergi's) is taking a ``...

I have a test implementation on my own branch, but I'm not sure if there's just a better way that doesn't require branchign: ``` if isinstance(ref, ArrayMixin) and not isinstance(node.children[dummy_args.index(ref.symbol)],...

I'm also not sure why the members don't need to be copied for that code to work so I added that in.

I found another flaw with my implementation. When i do this loop: ``` indices = [] for index in ref.indices: indices.append(index.copy()) ``` The index references I'm copying are to the...

I tested moving this section into a new function and changed the above code fragment to this (without the assertion): ``` for index in ref.indices: if isinstance(index, Reference): self.replace_dummy_arg(index, node,...

112f9f0 contains only what I changed to get this working for my current use-case. If anyone picks this up then it can be a starting point (though I think it...

@arporter There's also a(t least one) bug in my implementation, the one I've found is the loop at lines 231-232. I had forgotten how `StructureReference`s worked at that point, so...