BungeePackFix icon indicating copy to clipboard operation
BungeePackFix copied to clipboard

Published 20 hours ago • verified publisher icon LoneDev6

Fixed hash equality check not working on Velocity

Open itsTyrion opened this issue 1 year ago • 8 comments

As is, equal_pack_attributes.hash does not function correctly on Velocity, because Objects.equals is used on a byte array, which only checks for reference equality, which cannot work because the getter always creates a clone. After a quick test, the resource pack seems to be correctly skipped.

itsTyrion avatar Feb 06 '24 23:02 itsTyrion

bump?

itsTyrion avatar Feb 23 '24 23:02 itsTyrion

@itsTyrion can you send a version working with velocity?

SliderKP avatar Mar 10 '24 19:03 SliderKP

Can do but I gotta rebase it on top of the fixes done since mine and I'm not on PC right now, ping me if I forget

itsTyrion avatar Mar 12 '24 04:03 itsTyrion

@itsTyrion can you send it to me too?

Hecker-01 avatar Apr 18 '24 09:04 Hecker-01

https://github.com/itsTyrion/BungeePackFix/releases/latest @Hecker-01

itsTyrion avatar Apr 22 '24 17:04 itsTyrion

Thanks! and btw @LoneDev6 please merge xD

Hecker-01 avatar Apr 22 '24 17:04 Hecker-01

@LoneDev6 ? please merge this 💯

SwartZCoding avatar Jul 15 '24 07:07 SwartZCoding

" I will accept pull requests as soon as they work correctly."

this one has been working correctly since.. always

itsTyrion avatar Nov 01 '24 14:11 itsTyrion