BungeePackFix icon indicating copy to clipboard operation
BungeePackFix copied to clipboard

BungeePackFix 1.1.3 When using Minecraft 1.20.2, switching servers does not skip resource pack loading, it always reloads

Open tygh89071388 opened this issue 2 years ago • 23 comments

When using Minecraft 1.20.2, switching servers does not skip resource pack loading, it always reloads

Everything works fine when using 1.20.1.

This server is running Paper version git-Paper-169 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: b4e3b3d) This server is running Waterfall version git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:0e657ed:545 by md_5

tygh89071388 avatar Oct 07 '23 23:10 tygh89071388

i have the same problem.

SrFirox avatar Oct 08 '23 18:10 SrFirox

Check if you set ignore hash false in config.yml of BungeePackFix, it might be the reason. The plugin was tested and working before publishing the update.

LoneDev6 avatar Oct 09 '23 07:10 LoneDev6

Hey, its not misconfigured. Have the same issue, only 1.20.2 is still redownloading the pack, but lower versions not. Even if I set ignore hash to false in config.yml of BungeePackFix. Please fix it :/

EDIT: Setting hash to false just mess up all versions below 1.20.2. When set to true, only 1.20.2 not working.

naikyys avatar Oct 09 '23 22:10 naikyys

Can you confirm that 1.20.2 requires ignore hash to be set to false in order to avid redownloading the pack each time?

LoneDev6 avatar Oct 10 '23 10:10 LoneDev6

Can you confirm that 1.20.2 requires ignore hash to be set to false in order to avid redownloading the pack each time?

No. You have to just fix that 1.20.2 is still redownloading and versions below 1.20.2 are fine.

naikyys avatar Oct 12 '23 20:10 naikyys

i have the same issue. When will the fix come?

SuprexDE avatar Oct 13 '23 21:10 SuprexDE

Is it please possible to fix it please?... As you can see, many people having the same issue.

naikyys avatar Oct 16 '23 21:10 naikyys

I created a pull request at https://github.com/LoneDev6/BungeePackFix/pull/48 and that should fix this issue.

nhanledev avatar Oct 21 '23 10:10 nhanledev

It's related to a Minecraft bug which we can't fix for now. https://bugs.mojang.com/browse/MC-265673

LoneDev6 avatar Oct 23 '23 11:10 LoneDev6

It got suggested to feedback.minecraft since they deem this as feature request, here is the link to vote for it.

https://feedback.minecraft.net/hc/en-us/community/posts/20698154329869-Don-t-reset-the-resource-pack-when-entering-configuration-phase

Domm1 avatar Oct 31 '23 15:10 Domm1

mojang added this feature.

https://www.minecraft.net/en-us/article/minecraft-1-20-3-pre-release-1

jhqwqmc avatar Nov 20 '23 16:11 jhqwqmc

Did they fix the issue? Did they revert the logic or changed it again?

LoneDev6 avatar Nov 20 '23 17:11 LoneDev6

Maybe changed a little logic, also restored some logic image

jhqwqmc avatar Nov 20 '23 17:11 jhqwqmc

Is there any news about 1.20.2 and if Mojang's changes helped to fix the compatibility issue?

Aitooor avatar Dec 11 '23 21:12 Aitooor

Seems like Mojang already fixed the issue with reloading texture packs, so fixing it shouldn't be that big of a deal.

derMiepz avatar Jan 03 '24 23:01 derMiepz

They (Mojang) change the resource pack logic completely to other packet from 1.20.3, so Lone has to rewrite some additional codes to fix that.

nhanledev avatar Jan 04 '24 03:01 nhanledev

I created a pull request at #48 and that should fix this issue.

@nhanledev Could you make a fork of latest version of the plugin with your fix for 1.20.2 with a jar file. I need it a lot

SimonMage avatar Jan 05 '24 17:01 SimonMage

1.20.2 is a bugged version and it's not planned to be added as compatibility because people should stop using it. Use 1.20.3 instead. 1.20.3 support is added in the new Bungeepackfix update. 1.20.2 clients won't be handled by Bungeepackfix anymore so the plugins can send packs anytime, so clients should correctly see the pack sent each time they change server.

Let me know if it works on 1.20.3+ Download: https://github.com/LoneDev6/BungeePackFix/releases/tag/1.1.5-beta-1

LoneDev6 avatar Jan 09 '24 16:01 LoneDev6

1.20.2 is a bugged version and it's not planned to be added as compatibility because people should stop using it. Use 1.20.3 instead. 1.20.3 support is added in the new Bungeepackfix update. 1.20.2 clients won't be handled by Bungeepackfix anymore so the plugins can send packs anytime, so clients should correctly see the pack sent each time they change server.

Let me know if it works on 1.20.3+ Download: https://github.com/LoneDev6/BungeePackFix/releases/tag/1.1.5-beta-1

i got same issue... cant use 1.20.3 this will break all my custom maps....

el211 avatar Jan 12 '24 12:01 el211

1.20.2 is a bugged version and it's not planned to be added as compatibility because people should stop using it. Use 1.20.3 instead. 1.20.3 support is added in the new Bungeepackfix update. 1.20.2 clients won't be handled by Bungeepackfix anymore so the plugins can send packs anytime, so clients should correctly see the pack sent each time they change server.

Let me know if it works on 1.20.3+ Download: https://github.com/LoneDev6/BungeePackFix/releases/tag/1.1.5-beta-1

It does not work properly in version 1.20.4. I use Flamecord and in most of the things I do, it gives the error "disconnected with: DecoderException: io.netty.util.IllegalReferenceCountException: refCnt: ​​0, decrement: 1 @ io.netty.handler.codec.MessageToMessageDecoder:98" and throws it out of the game. It gets fixed when I delete bungeepackfix.

ttt0 avatar Jan 15 '24 06:01 ttt0

Hello; i use 1.20.4 but the plugin on the bungee doesn't seem to create an error; but the texture pack reloads between servers.. Does anyone have a solution?? even a crazy one Sans titre

victordumoulin avatar Jan 18 '24 00:01 victordumoulin

1.20.3 and 1.20.4 are working fine, but previous versions such as 1.19.4 or 1.20.1 stopped working. It seems that you removed support for those versions because the resourcepack is sent each time they change server.

TerryLVM avatar Jan 18 '24 10:01 TerryLVM

1.20.3 and 1.20.4 are working fine, but previous versions such as 1.19.4 or 1.20.1 stopped working. It seems that you removed support for those versions because the resourcepack is sent each time they change server.

I need to see your BungeePackFix settings file.

The strange thing is that I tested the plugin extensively before release and everything works as intended on my end. The only not working version is 1.20.2 and it won't be supported as it's bugged and Mojang fixed the issue on 1.20.3.

Note for me: LuluxClient offered beta testing help. https://github.com/PluginBugs/Issues-ItemsAdder/issues/3387#issuecomment-1921080121

LoneDev6 avatar Jan 29 '24 14:01 LoneDev6

These are my settings:

messages: minimessage_support: false ignored_pack: enabled: true message: "&7Texturepack cargado con éxito" equal_pack_attributes: hash: true forced: true prompt_message: true modern_uuid: true ignore_hash_in_url: true main_spigot_server_name: lobby1 ignored_servers: enabled: false invert_check: false list: - MULTIFFA-1 - DUELS-1 - DUELS-2 log: ignored_respack: false sent_respack: false debug: false cancel_modern_resourcepack_remove_packet: true

TerryLVM avatar Jan 29 '24 19:01 TerryLVM