Stringlate icon indicating copy to clipboard operation
Stringlate copied to clipboard

PR explanation

Open CrimsonFork opened this issue 7 years ago • 7 comments

It would be nice if SL had an explanation about PRs im the help section.

Like, I am a noob and I don't really know what it does, but people keep suggesting I should use them, but when I try, it says it will clone the repo, which does not sound like something I want, but I have no idea.

CrimsonFork avatar Jun 05 '18 05:06 CrimsonFork

Yes. You fork the repo actually (Github does) and you commit your modifications to your repo, then you open a PR from your repo with these changes to the original repo for integration in there.

Read about how Github works.

licaon-kter avatar Jun 05 '18 05:06 licaon-kter

That's what I thought, but I wasn't sure. It wouldnbe nice if you influded that text (more or less) in the current help.

On June 5, 2018 7:58:16 AM GMT+02:00, Licaon_Kter [email protected] wrote:

Yes. You fork the repo actually (Github does) and you commit your modifications to your repo, then you open a PR from your repo with these changes to the original repo for integration in there.

Read about how Github works.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/LonamiWebs/Stringlate/issues/227#issuecomment-394591045

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

CrimsonFork avatar Jun 05 '18 06:06 CrimsonFork

Which is the point of this issue.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

CrimsonFork avatar Jun 05 '18 06:06 CrimsonFork

We could probably add a section to help/en.md explaining what "PR" or "Pull Request" means.

Lonami avatar Jun 05 '18 08:06 Lonami

You mean what comes when you click on the question mark? That's what I meant then.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

CrimsonFork avatar Jun 05 '18 08:06 CrimsonFork

Yes, that file is what the question mark uses.

Lonami avatar Jun 05 '18 08:06 Lonami

Sorry for noobing around, just wanted to be sure.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

CrimsonFork avatar Jun 05 '18 08:06 CrimsonFork