Open-Source-Orchard-Core-Extensions icon indicating copy to clipboard operation
Open-Source-Orchard-Core-Extensions copied to clipboard

OSOE-464: OSOCE NuGetTest UI testing randomly getting stuck under Windows in Lombiq.UITestingToolbox

Open Piedone opened this issue 2 years ago • 1 comments

OSOE-464

Piedone avatar Nov 12 '22 16:11 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Nov 14 '22 00:11 github-actions[bot]

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Nov 14 '22 10:11 github-actions[bot]

If I understand correctly this branch won't be merged yet, right?

sarahelsaig avatar Nov 14 '22 23:11 sarahelsaig

Not yet, only when I figure out the issue.

Piedone avatar Nov 14 '22 23:11 Piedone

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Nov 17 '22 16:11 github-actions[bot]

Is this deliberately not yet merged?

Piedone avatar Nov 17 '22 19:11 Piedone

I was waiting for the tests to finish since I had to merge from dev, but I had to leave on an errand.

sarahelsaig avatar Nov 17 '22 20:11 sarahelsaig

So you're saying that errands are more important than my PR 🥺.

Piedone avatar Nov 17 '22 20:11 Piedone

I'm saying that if there was a "merge on my behalf if all tests pass" switch/bot then none of this would've happened.

sarahelsaig avatar Nov 17 '22 20:11 sarahelsaig

There actually is! https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request I'll look into this.

Piedone avatar Nov 17 '22 20:11 Piedone

Long live the geek in you! 🤓

0liver avatar Nov 17 '22 20:11 0liver