wide u32x8 compare methods implemented as functions and not as traits

u32x8 compare methods implemented as functions and not as traits

Open RazrFalcon opened this issue 4 years ago • 6 comments

Jan 24 '21 23:01 RazrFalcon

say what now?

Jan 25 '21 01:01 Lokathor

https://github.com/Lokathor/wide/blob/cb91288ded8f2c2101cd23f2a64bede67240f4e3/src/u32x8_.rs#L254

https://github.com/Lokathor/wide/blob/cb91288ded8f2c2101cd23f2a64bede67240f4e3/src/u32x4_.rs#L177

Jan 25 '21 12:01 RazrFalcon

Oh. but it looks like those methods also exist in the latest of the main branch? And in the published 0.6.4 version.

Where are you not seeing them available?

Jan 25 '21 18:01 Lokathor

Yes, they exist. But in f32x8 they are implemented as traits, not as methods.

Jan 25 '21 18:01 RazrFalcon

Oh, that, yeah. If you want to have the trait option just make a PR for trait impls that call the method. We can get that published real quick.

Jan 25 '21 18:01 Lokathor

No, I don't actually use them. Just noticed this issue while was reading the code. It can be fixed at any time.

Jan 25 '21 18:01 RazrFalcon