impl std::io::Write for TinyVec<[u8; x]>

Open eeeebbbbrrrr opened this issue 4 years ago • 5 comments

Would y'all accept a PR that implements std::io::Write for u8-based TinyVecs?

If so, I'd be thrilled to submit it.

Sep 22 '21 23:09 eeeebbbbrrrr

Yes. I'd love it. It should be behind a feature named std but otherwise I think you can figure out the rest.

Sep 23 '21 00:09 Lokathor

Consider it done. Thanks!

Sep 23 '21 00:09 eeeebbbbrrrr

I have a question regarding a std feature...

How do I use that to defeat the #![no_std] at the top of src/lib.rs? This is probably my lack of Rust knowledge showing...

Sep 23 '21 23:09 eeeebbbbrrrr

you'd change that to #![cfg_attr(not(feature = "std"), no_std)]

Sep 23 '21 23:09 Lokathor

Thank you. I'd have never figured that out.

I'll put up a PR tomorrow. It was overly simple to implement. Y'all did a great job with TinyVec. Every time I find a use for it in my projects performance improves measurably. It's such a valuable crate.

Sep 23 '21 23:09 eeeebbbbrrrr