tab-counter-plus icon indicating copy to clipboard operation
tab-counter-plus copied to clipboard

Counter Readability in Dark Mode

Open Riajyuu opened this issue 6 years ago • 1 comments

Firefox has built-in dark theme. When users set normal or light theme, dark counter is still good. But it is completely unreadable when user sets to dark one. The solution is to add listener to theme changing. When users set the dark one, change text to white. If you don't know how, this can help: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/theme/onUpdated

Riajyuu avatar Sep 18 '18 11:09 Riajyuu

I have been thinking about this. The problem is that theme.onUpdated is rather useless, because it's only fired when calling theme.update() or similar, but not when the user changes the theme.

The way to define different browserAction icons depending on the theme is theme_icons in the manifest, but can't be set programmatically. See https://bugzilla.mozilla.org/show_bug.cgi?id=1484840

Loirooriol avatar Sep 18 '18 12:09 Loirooriol