react-styled-flexboxgrid icon indicating copy to clipboard operation
react-styled-flexboxgrid copied to clipboard

Cannot replace `em` or `rem` with `px`

Open TomSaporitoXO opened this issue 6 years ago • 2 comments

I really think that you should add an alternative field to specify the unit for widths: containerUnits: 'px' And allow the xs md etc properties to accept pixels

TomSaporitoXO avatar Dec 20 '18 19:12 TomSaporitoXO

Hi @TomSaporitoXO Thanks for your first issue ever on Github ;)

Yep... maybe. But rem and em are well supported by modern browsers: https://caniuse.com/#feat=rem

I suggest you try to implement it and submit a pull request. We'll be able to discuss about that.

LoicMahieu avatar Jan 02 '19 11:01 LoicMahieu

My main issue with it is how to do with percentage. For example, if i happen to have a padding in one div, then all the number in rem seems just stop working properly.

windmaomao avatar Oct 23 '19 21:10 windmaomao