redux-logger icon indicating copy to clipboard operation
redux-logger copied to clipboard

fix: added babel transform-object-assign to fix IE support

Open Pwntastic opened this issue 7 years ago • 5 comments

Using native Object.assign was breaking IE support, so I pulled in babel-plugin-transform-object-assign to add in a polyfill when necessary.

Also the linter was complaining about the quotes around TRACE so I fixed that too.

Pwntastic avatar Aug 29 '17 22:08 Pwntastic

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@539dab5). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #255   +/-   ##
=======================================
  Coverage          ?    82%           
=======================================
  Files             ?      5           
  Lines             ?    150           
  Branches          ?      0           
=======================================
  Hits              ?    123           
  Misses            ?     27           
  Partials          ?      0
Impacted Files Coverage Δ
src/core.js 73.33% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 539dab5...bc923ec. Read the comment docs.

codecov-io avatar Aug 29 '17 22:08 codecov-io

what's going on with this one? why is this PR not merged?

cyberhck avatar Sep 22 '17 02:09 cyberhck

Is there anything that I specifically need to do?

Pwntastic avatar Sep 26 '17 14:09 Pwntastic

it almost looks like author of this repo didn't even look at this PR :smile:

BTW to make tests pass, you need to ADD some tests, reason those are failing is because redux-logger doesn't have enough test coverage.

cyberhck avatar Sep 28 '17 01:09 cyberhck

just spent an hour figuring it out, can this be merged please.

z-vr avatar Nov 15 '17 17:11 z-vr