grpc-spring-boot-starter icon indicating copy to clipboard operation
grpc-spring-boot-starter copied to clipboard

Support for non-boot Spring applications

Open JesseEstum opened this issue 6 years ago • 7 comments

Is there any interest in refactoring the non-boot parts of the library out into a separate module so that non-boot spring applications could take advantage of the library?

I did some initial investigation and it seems like this shouldn't be too difficult to refactor. If there is interest, I could start working on a PR.

JesseEstum avatar Jul 12 '18 12:07 JesseEstum

That would be great. I have been looking to add Grpc server capability to one of my spring applications that does not use boot.

lourduraj avatar Jul 14 '18 19:07 lourduraj

I wonder why would you want to get rid of bootable features?

jvmlet avatar Jul 15 '18 19:07 jvmlet

This is a legacy application deployed in web sphere which does not use boot.

lourduraj avatar Jul 15 '18 23:07 lourduraj

This is my use case as well. We have some applications that are using Spring DI/MVC but are not using Spring Boot. Due to various factors, porting the application to Spring Boot is not an option.

Basically the idea would be to allow gRPC server functionally in an application by leveraging the code here, but have an option to do it without dependency on any Spring Boot libraries.

On Sun, Jul 15, 2018, 6:51 PM lourduraj [email protected] wrote:

This is a legacy application deployed in web sphere which does not use boot.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LogNet/grpc-spring-boot-starter/issues/87#issuecomment-405127435, or mute the thread https://github.com/notifications/unsubscribe-auth/AcGG00XLhcGPfOKX-5JXB7nkWxzQvsWbks5uG9WKgaJpZM4VMzPQ .

JesseEstum avatar Jul 16 '18 02:07 JesseEstum

Understood. Sorry but I don't think that legacy applications support feature is something that should be added and maintained onwards, at least in this repository. I would suggest to copy-paste essential parts from this repo to your legacy app as one time shot fix.

jvmlet avatar Jul 16 '18 06:07 jvmlet

Hava a look at https://github.com/salesforce/grpc-java-contrib/tree/master/grpc-spring

l10178 avatar Oct 22 '18 09:10 l10178

Updated link: https://github.com/salesforce/grpc-java-contrib/tree/master/contrib/grpc-spring

rmichela avatar May 16 '19 19:05 rmichela