grpc-spring-boot-starter icon indicating copy to clipboard operation
grpc-spring-boot-starter copied to clipboard

implement grpc request scope

Open bherrmann2 opened this issue 3 years ago • 13 comments

This is to port over the grpc request scope added in https://github.com/yidongnan/grpc-spring-boot-starter in the following PR https://github.com/yidongnan/grpc-spring-boot-starter/pull/259 (by @ST-DDT)

@Bean
@Scope(scopeName = GRpcRequestScope.GRPC_REQUEST_SCOPE_NAME, proxyMode = ScopedProxyMode.TARGET_CLASS)
BeanType beanName() {
        return new BeanType();
}

bherrmann2 avatar Apr 05 '21 21:04 bherrmann2

@jvmlet can you take a look at this?

bherrmann2 avatar Apr 09 '21 14:04 bherrmann2

Did you ask the author of this feature if he is OK with copying the implementation as is?

jvmlet avatar Apr 09 '21 15:04 jvmlet

The copyright notice in the code gives explicit permission to copy it, but I can attempt to reach out

bherrmann2 avatar Apr 09 '21 15:04 bherrmann2

I have reached out here: https://github.com/LogNet/grpc-spring-boot-starter/issues/177#issuecomment-816773908

bherrmann2 avatar Apr 09 '21 15:04 bherrmann2

I consent to my code being ported over.

ST-DDT avatar Apr 11 '21 12:04 ST-DDT

I have now tagged you in the PR description @ST-DDT . I wasn't able to before you approved/commented on the PR since you weren't a contributor on this project.

bherrmann2 avatar Apr 11 '21 21:04 bherrmann2

FFR: It is possible even without that, but auto completion does not work.

ST-DDT avatar Apr 11 '21 21:04 ST-DDT

@jvmlet I got the permission and approval. Let me know if this is ok

bherrmann2 avatar Apr 15 '21 14:04 bherrmann2

@jvmlet can you take another look?

bherrmann2 avatar Apr 30 '21 15:04 bherrmann2

@jvmlet Can you please review this? I would still like to get this in

bherrmann2 avatar May 26 '21 14:05 bherrmann2

Can you please merge it?

deft1991 avatar Jul 19 '21 11:07 deft1991

@deft1991 . We need @jvmlet to reivew, approve, and merge.

bherrmann2 avatar Jul 19 '21 16:07 bherrmann2

@jvmlet is there any update? I want to use this feature.

hehe717 avatar Aug 25 '21 06:08 hehe717