grpc-spring-boot-starter
grpc-spring-boot-starter copied to clipboard
implement grpc request scope
This is to port over the grpc request scope added in https://github.com/yidongnan/grpc-spring-boot-starter in the following PR https://github.com/yidongnan/grpc-spring-boot-starter/pull/259 (by @ST-DDT)
@Bean
@Scope(scopeName = GRpcRequestScope.GRPC_REQUEST_SCOPE_NAME, proxyMode = ScopedProxyMode.TARGET_CLASS)
BeanType beanName() {
return new BeanType();
}
@jvmlet can you take a look at this?
Did you ask the author of this feature if he is OK with copying the implementation as is?
The copyright notice in the code gives explicit permission to copy it, but I can attempt to reach out
I have reached out here: https://github.com/LogNet/grpc-spring-boot-starter/issues/177#issuecomment-816773908
I consent to my code being ported over.
I have now tagged you in the PR description @ST-DDT . I wasn't able to before you approved/commented on the PR since you weren't a contributor on this project.
FFR: It is possible even without that, but auto completion does not work.
@jvmlet I got the permission and approval. Let me know if this is ok
@jvmlet can you take another look?
@jvmlet Can you please review this? I would still like to get this in
Can you please merge it?
@deft1991 . We need @jvmlet to reivew, approve, and merge.
@jvmlet is there any update? I want to use this feature.