sage-directives icon indicating copy to clipboard operation
sage-directives copied to clipboard
verified publisher icon Log1x

fix(directive): Fix @image directive not re-compiling view when using ACF field

Open JakeJolt opened this issue 2 years ago • 1 comments

When using @image directive with an ACF field name, the Blade view was not re-compiling after updating field value. This PR fixes this bug by moving the get_field call directly into the Blade echo rather than passing the field value.

Closes #117

JakeJolt avatar Aug 23 '23 09:08 JakeJolt

@Log1x is there anything I can do to help get this ready for inclusion in the next release? It's my first public PR so open to any feedback if it needs anything changing.

JakeJolt avatar Nov 23 '23 14:11 JakeJolt

The underlying issue on this was a little more complicated and was hopefully fixed in #144

Log1x avatar Mar 26 '24 13:03 Log1x