modern-login icon indicating copy to clipboard operation
modern-login copied to clipboard

Registration

Open nlemoine opened this issue 5 years ago • 9 comments

Hi,

Thanks for this great little plugin which provides login customization in no time!

There's a little issue with the registration form:

Capture d’écran 2020-09-15 à 10 49 15

Maybe it would be more secure to set a safer base text color?

nlemoine avatar Sep 15 '20 08:09 nlemoine

I don't have any sites with registration open so I didn't really think of this. None of the styles were meant target the register form in particular but I will try to push a fix when I get time so it works nicely.

Log1x avatar Sep 15 '20 08:09 Log1x

Thanks @Log1x !

nlemoine avatar Sep 15 '20 09:09 nlemoine

let me know if the update I pushed works. I don't have a complex register form to test against

Log1x avatar Sep 15 '20 15:09 Log1x

Thanks, that's better.

Some texts are still white on white. I'll have a look as soon as I can.

Capture d’écran 2020-09-15 à 18 02 45

nlemoine avatar Sep 15 '20 16:09 nlemoine

The admin email verification screen also suffers the same issue.

Capture d’écran 2020-09-17 à 12 20 41

nlemoine avatar Sep 17 '20 10:09 nlemoine

Is this still a problem? I may be able to help

pablobh avatar Apr 11 '21 03:04 pablobh

It is! I started working on this a while ago but it's missing a dev environment and testing all use cases is a bit tedious.

Maybe dumping static HTML (login.html, lost-password.html, etc.) would make dev/testing easier?

nlemoine avatar Apr 13 '21 14:04 nlemoine

@nlemoine That may be easier for me. That way I'll have all the fields from your custom registration.

Also, a few days ago I did a few fixes to a couple of css classes, can you confirm that the problem is still there after this update?

pablobh avatar Apr 13 '21 17:04 pablobh

@pablobh Sorry, I didn't have time to work this until now.

You'll find in the referenced PR a testing environnement that will make fixing a lot easier.

Also, a few days ago I did a few fixes to a couple of css classes, can you confirm that the problem is still there after this update?

It's better in some cases but I think there's still some improvements to be done.

localhost_3000_wp-login php_action=register localhost_3000_wp-login php_action=register (1)

But hopefully, if the PR gets merged, it will be easier to discuss and test things ;)

nlemoine avatar May 05 '21 11:05 nlemoine