Brandon

Results 197 comments of Brandon

I'm not sure why your Composer is pulling version `^1.0.0` of DiscordPHP – are you providing a version constraint when requiring it? You could try requiring it with `-W` maybe?...

> His problem isn't that. DiscordPHP has no stable release, and composer is pulling the latest stable. He should require latest RC version. Good catch! I tunneled and didn't see...

~~This should be about ready once https://github.com/discord-php/DiscordPHP-Http/pull/28 is merged.~~ The only thing I was unsure of is the namespace for the poll create request part. I feel like it should...

It should be simplified to `$example->addPartial(YourPartial::class)` now.

Oh, I think you can just pass the partial straight to `->addLayout` now the same as my `addPartial` example above: https://github.com/Log1x/acf-composer/blob/284c40b61e6efeea0995f1c0951c9606b7d021e1/src/Builder/FlexibleContentBuilder.php#L64-L75 Sorry, I never use Flexible Content anymore so I...

Also, assuming all works well – we can probably get a rule for that in the upgrade command. https://github.com/Log1x/acf-composer/blob/master/src/Console/UpgradeCommand.php#L49

Ah I see. It's good the latter works – but I think we can make it a bit better in the future. 👍

hey! def maintain any repo you see of mine that isn't archived. appreciate the PR! can you lint it? looks like spacing got a little wild. will otherwise review when...

I think translations ultimately don't get handled properly anyway once the config is cached, so we can just remove the `__()` from those strings for now. I think the only...

Will try to test this soon. Sorry for the delay.