acf-composer icon indicating copy to clipboard operation
acf-composer copied to clipboard

Allow localization of option page's name and title

Open laundy opened this issue 3 months ago • 2 comments

First of all: Incredible work, I use the package a lot! 🤩

I've noticed that the option page is not localizable yet, so I've just added the necessary functionality. Also, I've included the $position in the options.stub and added a hint for developers to change the $position, otherwise only one (or none) will be displayed.

Please also test the code and I'd be happy if the change gets merged.

laundy avatar Sep 06 '25 18:09 laundy

Hey! Thanks for this. I'm glad you like ACF Composer.

Everything looks good, but would you mind dropping the// TODO: change to another value if you have multiple option pages. comment from the stubs? 👀 I'd be open to something in stub generation that auto-iterates that value in the future but otherwise just not huge on the inline comment.

Log1x avatar Sep 18 '25 08:09 Log1x

Thanks for your feedback. Sure, the todo comments are removed.

laundy avatar Sep 18 '25 17:09 laundy