Lodestone-Team
290 desktop client should not force user to setup a local core
Description
Added way for users to skip local core setup in initial page load in Tauri:
Added extra button in core select page in Tauri for local setup later on - this works by selecting the first option that shows up in Tauri, which might not work in all cases.
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
Note: make sure your files are formatted with rust-analyzer
Deploy Preview for lodestone-dashboard ready!
| Name | Link |
|---|---|
| Latest commit | bb7aad329478955f869544f67cfe236d0d815931 |
| Latest deploy log | https://app.netlify.com/sites/lodestone-dashboard/deploys/64e94b41880f4200088395b5 |
| Deploy Preview | https://deploy-preview-324--lodestone-dashboard.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for lodestone-storybook ready!
| Name | Link |
|---|---|
| Latest commit | bb7aad329478955f869544f67cfe236d0d815931 |
| Latest deploy log | https://app.netlify.com/sites/lodestone-storybook/deploys/64e94b41b3584c000740069c |
| Deploy Preview | https://deploy-preview-324--lodestone-storybook.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
We need to disable this popup in this usecase (tauri & localcore not setup & on dashboard page looking at external cores)
This button still says "setup" even if the local core is already setup.
We should remove this button, or change the text to be more general like "use local core".
This page might benefit from a "back" button
This page might benefit from a "back" button
which page should we go back to? in this issue there are 2 ways of going to that page, from this one:
and this one:
We need to disable this popup in this usecase (tauri & localcore not setup & on dashboard page looking at external cores)
could you clarify on the exact steps you did to get this? i can't seem to get to this popup
Regarding back button, I think the default browser "navigate backward" behavior might be enough. For the "new local core detected" prompt, reproduce it like this:
- setup lodestone core on a separate machine
- delete your local lodestone core
- open lodestone desktop, click connect to existing core
- enter details and get to the dashboard
- it should show up