ember-d3-helpers icon indicating copy to clipboard operation
ember-d3-helpers copied to clipboard

[WIP] Update ember-cli to 3.0 (needs clean-up)

Open jacobq opened this issue 7 years ago • 5 comments

This is a test PR just to try TravisCI builds while troubleshooting PR #45

jacobq avatar Feb 28 '18 16:02 jacobq

@chilicoder I ended up spending a little more time playing with this (for practice / out of curiousity) than I expected. I updated ember-cli to 3.0 and ran some codemods to get things closer to current conventions. The tests are running & passing again, but there're still some things you'll want to fix aside from general clean-up & rebasing:

  • Would be good to eliminate bower.json by bringing in bootstrap through npm (if it's needed at all)
  • Would be good to eliminate jQuery using built-in APIs like document.querySelectorAll
  • Setup test scenarios for older versions of ember, if needed (e.g. 2.4 & 2.8). I think they'll need to be fetched outside of npm/yarn
  • I would highly recommend using yarn.lock (in fact I was just recently burned by not doing so)

jacobq avatar Feb 28 '18 17:02 jacobq

@jacobq awesome! Great job! Thank you! I will move bootstrap to npm in separate branch.

@zigahertz can you review this PR, please?

yarigpopov avatar Feb 28 '18 21:02 yarigpopov

@jacobq - beautiful work, thanks so much! I notice the "WIP" tag - is there anything left that you are wanting to work on here before merging?

ghost avatar Mar 05 '18 18:03 ghost

@zigahertz I left this marked as WIP because I considered it a spike left for someone else to "land". I recommended some next steps in my previous comment. I don't plan to do any more work with this, so feel free to take them or leave them (it's your project), but if it were my project I'd want to do some clean-up first and probably re-base/squash some those commits.

jacobq avatar Mar 05 '18 21:03 jacobq

Thanks @jacobq! Really appreciate your hard work and suggestions for what to do next. I am one of the collaboraters and I do not own this proejct. I don't have the bandwidth to take this on for the foreseeable future, and I know there are some folks needing this update. I will ask to see if someone else is up for finishing this.

ghost avatar Jun 25 '18 19:06 ghost