nix-darwin icon indicating copy to clipboard operation
nix-darwin copied to clipboard

Published 20 hours ago • verified publisher icon LnL7

Add persistent others to dock

Open rmgpinto opened this issue 1 year ago • 5 comments

Add persistent others to dock. Closes https://github.com/LnL7/nix-darwin/issues/927.

rmgpinto avatar Apr 08 '24 13:04 rmgpinto

@Enzime @Samasaur1

rmgpinto avatar Apr 08 '24 13:04 rmgpinto

@Samasaur1 I didn't notice, it's my linter and auto format on save. I've reverted the formatting changes.

rmgpinto avatar Apr 10 '24 07:04 rmgpinto

@Samasaur1 I can't seem to understand why the tests fail. Are you able to help?

rmgpinto avatar May 10 '24 15:05 rmgpinto

Okay I manually checked the failing test on unstable, and it's only failing because of a missing newline. Seems like a false alarm; let me take a closer look and determine whether it's better to change the test or change the implementation back

Samasaur1 avatar May 11 '24 04:05 Samasaur1

Ah, okay, you need another newline in the test file

Samasaur1 avatar May 11 '24 04:05 Samasaur1

Thanks @Samasaur1, tests passed.

rmgpinto avatar May 12 '24 21:05 rmgpinto

Can you rebase the PR?

Enzime avatar May 13 '24 00:05 Enzime

done @Enzime.

rmgpinto avatar May 13 '24 06:05 rmgpinto

Can you rebase your PR on top of the latest master and squash your commits? Ideally your branch shouldn't contain the fmt commits and should only contain your commits

Enzime avatar May 13 '24 12:05 Enzime

should be ok now @Enzime

rmgpinto avatar May 13 '24 12:05 rmgpinto

The tests seem to be flaky, sometimes that check passes, others it doesn't.

rmgpinto avatar May 13 '24 16:05 rmgpinto

This introduces a regression (warning) by using lib.mdDoc

mdDoc usage has been been removed in https://github.com/LnL7/nix-darwin/pull/932

thegleich avatar May 14 '24 22:05 thegleich

Fixing in https://github.com/LnL7/nix-darwin/pull/950

rmgpinto avatar May 15 '24 06:05 rmgpinto