nix-darwin icon indicating copy to clipboard operation
nix-darwin copied to clipboard

Published 20 hours ago • verified publisher icon LnL7

linux-builder additional options

Open LoganBarnett opened this issue 5 months ago • 1 comments

This wrangles together changes in the following pull requests (no particular order):

  1. #816 by @ethnt to add systems.
  2. #871 by @stv0g to add mandatoryFeatures and speedFactor.
  3. #877 by myself to add protocol.

I've done my best to preserve the original commits and keep authors' credit/contributions. I did take liberty of sorting the added parameters lexicographically. Additionally I applied the defaultText and literalExpression feedback from #816 to the other options.

Thanks for taking the time to review!

LoganBarnett avatar Feb 21 '24 21:02 LoganBarnett

Thanks, looks good to me :)

stv0g avatar Feb 22 '24 07:02 stv0g

I think the link to 871 (an issue I created) is an accident. I don't think this pr is related to that.

tmillr avatar Aug 11 '24 08:08 tmillr

@tmillr you are correct! Apologies, I must've fat fingered it. I meant #873. I've updated the PR description. I'm not really in a position to check on commit messages presently but I wouldn't be able to fix them there anyways.

LoganBarnett avatar Aug 11 '24 18:08 LoganBarnett