nix-darwin icon indicating copy to clipboard operation
nix-darwin copied to clipboard

Allow multiple tags with the same name in buildkite-agents.nix

Open HeinrichApfelmus opened this issue 1 year ago • 4 comments

It turns out that the buildkite-agent supports multiple tags with the same name — for example, one Agent can be in multiple queue at the same time. This pull request adds support for this use case.

Example buildkite-agent.cfg

tags="queue=default,queue=mickey,system=x86_64-darwin"

Here, the name queue appears twice.

Desired syntax in .nix configuration:

{ queue = ["default" "mickey"]; system = "x86_64-darwin"; };

The code is a copy&paste from the corresponding NixOS buildkite-agent service.

HeinrichApfelmus avatar Nov 23 '23 12:11 HeinrichApfelmus

The CI test test-stable (pull_request) fails with the error

/Users/runner/work/_temp/479957b6-fa59-4923-8891-5919bdfe1304.sh: line 1:  2063 Segmentation fault: 11  nix-build ./release.nix -I nixpkgs=channel:nixpkgs-23.05-darwin -I darwin=. -A tests

I do not know how to interpret this Segmentation fault.

HeinrichApfelmus avatar Nov 23 '23 12:11 HeinrichApfelmus

This error is unrelated to your PR, it's occurring on master atm and #819 should fix it :+1:

Enzime avatar Nov 23 '23 23:11 Enzime

The PR has been merged, can you rebase your branch over master now, and see if the tests still fail?

Enzime avatar Nov 23 '23 23:11 Enzime

The PR has been merged, can you rebase your branch over master now, and see if the tests still fail?

Done. All tests pass now. 😊

HeinrichApfelmus avatar Nov 24 '23 23:11 HeinrichApfelmus