nix-darwin icon indicating copy to clipboard operation
nix-darwin copied to clipboard

Uninstaller needs work

Open emilazy opened this issue 2 years ago • 5 comments

Just off the top of my head:

  • [ ] Needs to clean up /run, esp. after https://github.com/LnL7/nix-darwin/pull/687
  • [x] Didn't delete /Applications/Nix Apps when I tested in a VM, don't know why
  • [ ] Should restore pre-nix-darwin configuration like nix.conf, bashrc and zshrc
  • [ ] Flake uninstall procedure needs documenting in README
  • [ ] Update documentation to recommend running the uninstaller from $PATH

emilazy avatar Jul 11 '23 23:07 emilazy

I've fixed /Applications/Nix Apps not getting deleted in #687.

As opposed to the installer, I think uninstalling a flake-based system can be handled by the darwin-uninstaller, need to investigate further into any additional flake-specific logic that needs to be added.

Enzime avatar Jul 11 '23 23:07 Enzime

I've fixed /Applications/Nix Apps not getting deleted in #687.

That's what confuses me: I was using that version (nix run github:Enzime/...).

emilazy avatar Jul 11 '23 23:07 emilazy

I believe the uninstaller is not unloading launchd daemons before deleting the files, need to check this further.

Enzime avatar Sep 10 '23 11:09 Enzime

I thought I'd call this out here too, there's a small bootstrapping issue with the uninstaller being a derivation that has to be built to be run. If someone has any issues actually running nix, and they want to uninstall nix-darwin to get back to a clean state, they can't easily do that right now, since the docs recommend running from the derivation

zdcthomas avatar May 15 '24 01:05 zdcthomas

Some progress was made on this as of #806 as the uninstaller is now installed by default on all nix-darwin systems, accessible through darwin-uninstaller, so it no longer needs to be built, however I believe the uninstaller still depends on Nix.

The documentation should probably be updated to recommend running the uninstaller from $PATH

Enzime avatar May 16 '24 23:05 Enzime