nix-darwin icon indicating copy to clipboard operation
nix-darwin copied to clipboard

`system.activationScripts` missing `deps` attribute

Open montchr opened this issue 3 years ago • 0 comments

I've noticed, via https://github.com/ryantm/agenix/issues/60, that nix-darwin's system.activationScripts option does not include a declaration for deps while NixOS seems to expect it for each activation script (with a default value of an empty list).

From https://github.com/NixOS/nixpkgs/blob/8dd8bd8be74879f9f7919b16a4cb5ab2a75f18e5/nixos/modules/system/activation/activation-script.nix#L31-L43 :

  scriptType = with types;
    let scriptOptions =
      { deps = mkOption
          { type = types.listOf types.str;
            default = [ ];
            description = "List of dependencies. The script will run after these.";
          };
        text = mkOption
          { type = types.lines;
            description = "The content of the script.";
          };
      };
    in either str (submodule { options = scriptOptions; });

Because of this, I think, some modules (like the one provided by agenix, linked above) which provide a definition for an activation script with NixOS compatibility will fail with nix-darwin.

Disclaimer: I am new-ish to Nix and can not yet consider myself a NixOS user so I apologize if I've misunderstood the issue.

montchr avatar Sep 17 '21 14:09 montchr