nix-darwin icon indicating copy to clipboard operation
nix-darwin copied to clipboard

darwin-rebuild: use --no-link for flakes too

Open emilazy opened this issue 3 years ago • 8 comments

This appears to have been special‐cased because of the readlink -f result, but nix path-info gives us the same information. (Theoretically there might be an annoying race condition here where Nix refreshes the flake registry between the build and path-info errors out, but I think the consequences should be fairly harmless. Also not sure if ${extraLockFlags[@]} should be passed along here.)

emilazy avatar Mar 23 '21 09:03 emilazy

No idea what’s up with the failure.

emilazy avatar Mar 23 '21 09:03 emilazy

Rebased to use nix build --json; thanks to @ElvishJerricco for the pointer! Hopefully CI will actually run this time.

Note that there’s technically a race condition here in the presence of automatic GC, as described in https://github.com/NixOS/nix/pull/2423#issuecomment-471357147, but it was present already and seems difficult to fix, so whatever.

emilazy avatar Mar 23 '21 21:03 emilazy

Any update on this?

K900 avatar Oct 14 '21 19:10 K900

Also rebased for Christmas (and also no pressure to review/merge over the holidays).

emilazy avatar Dec 24 '21 03:12 emilazy

Also, fixes #375 (does this work in a comment?).

emilazy avatar Dec 24 '21 03:12 emilazy

@emilazy Can confirm that this works, have been using this fix for close to two months with no issues.

ryantking avatar Jan 03 '22 16:01 ryantking

Hey, I've also been using this fix with no issues for a few weeks now. Thanks! Would be great to get it merged 🚀

pbar1 avatar Mar 29 '22 18:03 pbar1

Could you rebase on master?

domenkozar avatar Aug 24 '22 08:08 domenkozar