nix-darwin
nix-darwin copied to clipboard
hercules-ci-agent: init
Source files originate from the hercules-ci-agent repository and I will make sure to keep them in sync, bidirectionally.
The module is split into two files to make maintenance of the common parts with NixOS easier.
Unlike the module that existed in the hercules-ci fork for a long time, this module reuses the hercules-ci-agent package from Nixpkgs, so it will require little maintenance in nix-darwin itself.
UPDATE: force-pushed to retry unrelated github actions failure UPDATE 2: still fails. It seems to be a nixUnstable bug, which is unrelated to this pr.
Closes #291
Also, will this not have the same issue with System Update that nixbld*
/ _nixbld*
appears to?
That depends on what the actual trigger for that problem is. Unlike that case most service users like this should have a homedir, which might result in the problem not occurring. If it also causes problems then that migration bug is even more crazy than I thought.
I've changed the user to a have a lower uid and an underscore prefix, as hinted by the previously referenced discussion https://github.com/NixOS/nix/pull/4532. Is there anything else I should change?
@LnL7 I've implemented the change. Do you think this can be merged?
I've added meta.maintainers
with the recommendation to use maintainers.alice or "alice"
instead of the usual Nixpkgs way. This wasn't strictly necessary for building nix-darwin configurations, but allows to build on top maintainers
even when the inevitable happens.
Is there anything I can do?
@roberth is this ready to go?
@roberth is this ready to go?
Has been for a long time, but let me update and test this first.
The stuff about system users is already ready to go afaic. I think this pr got a bit lost because of uncertainty around that change, if I may speculate :)
Oh I can't merge because @lnl7 is tagged as a reviewer
Closing while syncing up and testing.
@domenkozar I've opened a new PR
- #586