Jorge Fuentes comments

Results 91 comments of


                                            Jorge Fuentes

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

> I can't disagree with code simplicity, do you have benchmarks? I didn't run any benchmark. Going to do a PoC with iso-bench and post the result. > I mean,...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

EDIT: Invalid test. Rewriting...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

Done. Summary: - A **bit** of improvement on single comments, and equalizing the more lines the file has (from `1.16x` to `1.00x`). - A **lot** of worsening on multiple comments,...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

Ok, I tried with different approaches, and I think that I found a good balance between performance an code, as performance is good (even better with single and multiple comment...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

I'm not sure what subsystem this applies to...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

Ok, I'm going with lib as it was the very previous commit for these lines that I'm changing.

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

@legendecas I've modified the eval test. Do you think that's enough or you prefer a single file specific for this?

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

@legendecas I noticed a problem with the negative lookahead regex. If you have mixed `//# sourceMappingURL=` and `/* sourceMappingURL=` comments it will fail, so instead of explaining the regexes, I...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

Ok, at this point I don't know what is happening. A linter about prototype pollution fails with `StringPrototypeMatch` and I'm not sure why as I'm using the primordial like all...

Avoid match looping in sourceMappingURL tag detection by using negative lookahead

> Checkout https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match#description for explaination about the prototype pollution (i.e. `RegExp.prototype[Symbol.match]()` in this case). An alternative to `StringPrototypeMatch` is using `RegExpPrototypeSymbolMatch` directly Ahhh makes sense! Thank you.