rag-api-server icon indicating copy to clipboard operation
rag-api-server copied to clipboard

Redundant RUSTFLAGS in release.yml?

Open suryyyansh opened this issue 1 year ago • 4 comments

Are the RUSTFLAGS in release.yml still required after the addition of the .cargo folder?

suryyyansh avatar Sep 05 '24 13:09 suryyyansh

@apepkuss Could I get an update for this. Thanks.

suryyyansh avatar Sep 10 '24 19:09 suryyyansh

Sorry for the late reply! Please do not update the release workflow, in case there is any bad effect on the releases. For the potential issue you mentioned above, we'll check it and update the workflow if necessary. Thanks a lot!

apepkuss avatar Sep 11 '24 02:09 apepkuss

I understand, but wouldn't it make sense to have an additional release asset for the search enabled rag-api-server? since it requires recompilation with the search feature to be used.

This is what I was going to include in my PR. Let me know what you think.

suryyyansh avatar Sep 13 '24 15:09 suryyyansh

Yes. I agree that we need release assets for the search-api-server.

juntao avatar Sep 14 '24 01:09 juntao