Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

fix(linux/kms): skip NVIDIA cards for VAAPI on hybrid GPU laptops

Open coleleavitt opened this issue 3 weeks ago • 4 comments

Description

Skip Nvidia cards if we're looking for VAAPI devices. This is important for hybrid GPU laptops where the display may be connected through NVIDIA but rendering happens on Intel.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • [ ] feat: New feature (non-breaking change which adds functionality)
  • [x] fix: Bug fix (non-breaking change which fixes an issue)
  • [ ] docs: Documentation only changes
  • [ ] style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • [ ] refactor: Code change that neither fixes a bug nor adds a feature
  • [ ] perf: Code change that improves performance
  • [ ] test: Adding missing tests or correcting existing tests
  • [ ] build: Changes that affect the build system or external dependencies
  • [ ] ci: Changes to CI configuration files and scripts
  • [ ] chore: Other changes that don't modify src or test files
  • [ ] revert: Reverts a previous commit
  • [ ] BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • [x] Code follows the style guidelines of this project
  • [x] Code has been self-reviewed
  • [x] Code has been commented, particularly in hard-to-understand areas
  • [ ] Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • [ ] Unit tests have been added or updated for any new or modified functionality

AI Usage

  • [ ] None: No AI tools were used in creating this PR
  • [ ] Light: AI provided minor assistance (formatting, simple suggestions)
  • [ ] Moderate: AI helped with code generation or debugging specific parts
  • [ ] Heavy: AI generated most or all of the code changes

coleleavitt avatar Dec 05 '25 17:12 coleleavitt

Thank you for the PR! I think this should target the master branch instead of the feature branch that was selected. Is it okay if I change the base branch?

ReenigneArcher avatar Dec 06 '25 19:12 ReenigneArcher

Thank you for the PR! I think this should target the master branch instead of the feature branch that was selected. Is it okay if I change the base branch?

yea go right ahead thank you

coleleavitt avatar Dec 06 '25 19:12 coleleavitt

Thank you for the PR! I think this should target the master branch instead of the feature branch that was selected. Is it okay if I change the base branch?

yea go right ahead thank you

Looks like that didn't quite work. Can you rebase your branch so it's based on our master branch?

ReenigneArcher avatar Dec 06 '25 20:12 ReenigneArcher